hoist HKDF into rust for even more speed #12995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
May 27, 2025
alex
reviewed
May 27, 2025
|
(you've got failing tests) |
This PR was done via zed+claude sonnet 4 (with some cleanup and additions) using the following prompt: Please implement HKDF in rust. You can follow the example in hmac.rs to see similar structure, but implement the general HKDF algorithm as seen in hkdf.py
Co-authored-by: Alex Gaynor <[email protected]>
alex
reviewed
Jun 13, 2025
src/rust/src/backend/kdf.rs
Outdated
Comment on lines
11
to
12
| use pyo3::prelude::PyAnyMethods; | ||
| use pyo3::types::PyBytesMethods; |
There was a problem hiding this comment.
Suggested change
| use pyo3::prelude::PyAnyMethods; | |
| use pyo3::types::PyBytesMethods; | |
| use pyo3::types::{PyAnyMethods, PyBytesMethods}; |
src/rust/src/backend/kdf.rs
Outdated
Comment on lines
547
to
548
| if actual_bytes.len() != expected_bytes.len() | ||
| || !openssl::memcmp::eq(actual_bytes, expected_bytes) |
There was a problem hiding this comment.
there's a utility function for this.
src/rust/src/backend/kdf.rs
Outdated
Comment on lines
667
to
669
| if actual_bytes.len() != expected_bytes.len() | ||
| || !openssl::memcmp::eq(actual_bytes, expected_bytes) | ||
| { |
alex
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was done via zed+claude sonnet 4 (with some cleanup and additions) using the following prompt:
Please implement HKDF in rust. You can follow the example in hmac.rs to see similar structure, but implement the general HKDF algorithm as seen in hkdf.py