Skip to content

feat: fixed should_reload behaviour, close PostgreSQL connections, block until PostgresqlWatcher is ready, refactorings #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

feat: fixed should_reload behaviour, close PostgreSQL connections, block until PostgresqlWatcher is ready, refactorings #28

wants to merge 27 commits into from

Conversation

trbtm
Copy link
Contributor

@trbtm trbtm commented Jul 8, 2024

  1. PostgresqlWatcher.update_callback gets called by should_reload
  2. Close connection to PostgreSQL when Process gets terminated
  3. Block the thread until PostgresqlWatcher is ready to receive updates
  4. Adjusted README to make it clear to the user that they have to call PostgresqlWatcher.should_reload before Enforcer.enforce
  5. Improved unit tests
  6. Run black on the whole project
  7. Other refactorings

trbtm added 15 commits July 8, 2024 12:17
@trbtm
chore: updated dev requirements
3edbf37
@trbtm
chore: format code with black
8101bcd
@trbtm
chore: updated .gitignore
98ed568
@trbtm
fix: type hint, multiprocessing.Pipe is a Callable and not a type
bb99917
@trbtm
fix: make Watcher.should_reload return value consistent
df1b804
@trbtm
fix: Handle Connection and Process objects consistenly and close them…
c6fb087 
… before creating new ones
@trbtm
feat: Customize the postgres channel name
434a84c
@trbtm
chore: Some code reorg
90689ef 
       - Make PostgresqlWatcher.create_subscription_process a private method
       - Rename casbin_subscription to _casbin_channel_subscription
@trbtm
docs: added doc string for PostgresqlWatcher.update
772a261
@trbtm
refactor: PostgresqlWatcher.set_update_callback
f94294e
@trbtm
refactor!: Rename 'start_process' flag to 'start_listening'
c26887c
@trbtm
docs: Added doc string to PostgresqlWatcher.__init__
bc33cf5
@trbtm
fix: Added proper destructor for PostgresqlWatcher
9aba002
@trbtm
chore: fix type hints and proper handling of the channel_name argumen…
eb5c8f3 
…t and its default value
@trbtm
test: fix tests
94e23d7 
      decrease select timeout to one second in child Process
      remove infinite timout in PostgresqlWatcher.should_reload
      create a new watcher instance for every test case
@trbtm trbtm mentioned this pull request Jul 8, 2024
Closed
@trbtm trbtm closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trbtm