Use actions instead of gh-pages branch #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split workflow into two sequential jobs (`build_book` and `deploy_book`), which use dedicated GitHub Actions: - `build_book` uses `configure-pages` and `upload-pages-artifact`; - `deploy_book` uses `deploy-pages`.
yguclu
changed the title
Also rename the names of the workflow and the build jobs
campospinto
reviewed
Mar 7, 2025
campospinto
left a comment
campospinto
left a comment
There was a problem hiding this comment.
Thanks Yaman!
Do you think we should add two lines on a "Contributing" section of the readme, to tell/explain how to review the book during a PR review ?
Member
Author
Good idea! I'll do that |
This mentions issues, forks, pull requests, workflows, and artifacts.
This was referenced Mar 7, 2025
yguclu
added a commit
to yguclu/IGA-Python
that referenced
this pull request
Mar 10, 2025
After PR pyccel#13 the deploy step of our workflows did not have the necessary permissions to upload our website to GitHub Pages. This should fix it.
yguclu
added a commit
that referenced
this pull request
Mar 10, 2025
After PR #13 the deploy step of our workflows did not have the necessary permissions to upload our website to GitHub Pages. This change fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the workflow into two sequential jobs (
buildanddeploy), which use dedicated GitHub Actions:buildjob matrix builds our HTML documentation for GitHub Pages, then it uploads artifacts with job-dependent names usingupload-pages-artifact. Hence the generated books can be checked during a PR review. This fixes Provide deploy preview in PRs #12.deployjob runs on a single platform after the PR is merged. It deploys the correct artifact to GitHub Pages usingdeploy-pages.NOTE: We do not need a dedicated branch
gh-pagesany longer.Other changes:
build-book.ymltobuild-deploy-book.ymlContributingsection toREADME.md, which mentions issues, forks, pull requests, workflows, and artifacts.AUTHORS.