-
Notifications
You must be signed in to change notification settings - Fork 21
Prepare release #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release #553
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Bundle `igakit` into `psydac` for publishing to PyPI. Use `meson-python` as build backend to achieve this. --------- Co-authored-by: Yaman Güçlü <[email protected]>
6b97a93 to
cba8192
Compare
FrederikSchnack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say much about the workflow files, but it looks good to me.
Btw, what is the reason for the folder structure? Having .github/actions with subfolders and .github/workflows?
Thanks for the review! The folder structure is the one required by GitHub Actions, I cannot say why they designed it that way 🤷♂️ |
Remove 'setup.py' from paths for push and pull request triggers.
Make the necessary changes for being able to upload the
psydacpackage to PyPI through a CI workflow:ubuntu_installandmacos_installfor installation of non-Python dependenciesigakitas agitsubmodulemeson-pythonas build backend to bundleigakitintopsydacfor publishing to PyPIsetup.pyafter droppingsetuptoolsbuild backendpsydac/version.pyread value frompyproject.toml--no-build-isolationshould be given topipwheelandnumpyfor buildingdeploy_checkworkflow which uploads PSYDAC to TestPyPI from a pull request into themainbranchdeployworkflow which uploads PSYDAC to PyPI after a merge into themainbranch