Skip to content

Conversation

@yguclu
Copy link
Member

@yguclu yguclu commented Dec 10, 2025

Make the necessary changes for being able to upload the psydac package to PyPI through a CI workflow:

  • Add actions ubuntu_install and macos_install for installation of non-Python dependencies
  • Require Python >= 3.10 (3.9 is no longer supported). Run tests with Python 3.14, too
  • Require Pyccel >= 2.1.0 and use its new subcommands
  • Update PETSc version to 3.24.2
  • Add igakit as a git submodule
  • Use meson-python as build backend to bundle igakit into psydac for publishing to PyPI
  • Remove setup.py after dropping setuptools build backend
  • Write PSYDAC in all caps across the whole repository
  • Avoid version duplication: have psydac/version.py read value from pyproject.toml
  • Update instructions for editable install: flag --no-build-isolation should be given to pip
  • Do not require wheel and numpy for building
  • Add deploy_check workflow which uploads PSYDAC to TestPyPI from a pull request into the main branch
  • Add deploy workflow which uploads PSYDAC to PyPI after a merge into the main branch

@codacy-production
Copy link

codacy-production bot commented Dec 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 60.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (96b4312) 32030 19896 62.12%
Head commit (e63f045) 64082 (+32052) 39806 (+19910) 62.12% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#553) 15 9 60.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@yguclu yguclu added the Next Release Must be in next release label Dec 12, 2025
@yguclu yguclu marked this pull request as ready for review December 22, 2025 22:02
@yguclu yguclu requested review from a team and kvrigor December 22, 2025 22:02
Copy link
Contributor

@FrederikSchnack FrederikSchnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about the workflow files, but it looks good to me.

Btw, what is the reason for the folder structure? Having .github/actions with subfolders and .github/workflows?

@yguclu
Copy link
Member Author

yguclu commented Dec 23, 2025

I can't say much about the workflow files, but it looks good to me.

Btw, what is the reason for the folder structure? Having .github/actions with subfolders and .github/workflows?

Thanks for the review!

The folder structure is the one required by GitHub Actions, I cannot say why they designed it that way 🤷‍♂️

@yguclu yguclu enabled auto-merge (squash) December 23, 2025 11:04
Remove 'setup.py' from paths for push and pull request triggers.
@yguclu yguclu merged commit 689127d into devel Dec 23, 2025
10 checks passed
@yguclu yguclu deleted the prepare-release branch December 23, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Next Release Must be in next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants