Add QUERY method support (RFC 10008)#1055
Conversation
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
1 issue found across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
mbeijen
left a comment
There was a problem hiding this comment.
Nice, thanks. I think the biggest problem is this here:
httpx2/src/httpx2/httpx2/_client.py
Lines 483 to 486 in 70fac53
On HTTP 302 (and NOT on other "redirecty" codes) we turn requests into GET. This is done because "reasons". But QUERY is like a GET so I strongly think that the methods should be preserved here. I'd like to hear thoughts from @Kludex on this though.
| """ | ||
| Sends a `QUERY` request. | ||
|
|
||
| **Parameters**: See `httpx.request`. |
There was a problem hiding this comment.
this one is still 'see httpx.request' instead of httpx2.request
| """ | ||
| Send a `QUERY` request. | ||
|
|
||
| **Parameters**: See `httpx.request`. |
Summary
Implements the
QUERYHTTP method as defined in RFC 10008 — a safe, idempotent method that carries a request body to express a query predicate.Checklist