Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vecdot compliant to the Array API #850

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Mar 13, 2025

Trying to fix :

test_vecdot - AssertionError: out.dtype=uint64, but should be uint8 [vecdot(uint8, uint8)]

while running array_api_tests.

@prady0t prady0t marked this pull request as draft March 13, 2025 11:43
@hameerabbasi
Copy link
Collaborator

You need to remove the line

array-api-tests/array_api_tests/test_linalg.py::test_vecdot

from ci/Numba-array-api-xfails.txt as well.

@hameerabbasi hameerabbasi changed the title Array api errors Make vecdot compliant to the Array API Mar 13, 2025
Copy link

codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #850 will not alter performance

Comparing prady0t:array-api-errors (e2e472d) with main (3174527)

Summary

✅ 340 untouched benchmarks

@prady0t prady0t marked this pull request as ready for review March 13, 2025 18:15
@hameerabbasi hameerabbasi enabled auto-merge (squash) March 14, 2025 04:13
@hameerabbasi hameerabbasi merged commit 965c8d8 into pydata:main Mar 14, 2025
18 of 19 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks, @prady0t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants