-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New defaults for concat
, merge
, combine_*
#10062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5c56acf
5461a9f
e16834f
9c50125
b0cf17a
0026ee8
4d4deda
5a4036b
912638b
67fd4ff
4f38292
51ccc89
aa3180e
93d2abc
e517dcc
0e678e5
37f0147
dac337c
a0c16c3
4eb275c
03f1502
f1649b8
7dbdd4a
c6a557b
9667857
42cf522
8d0d390
ba45599
90bd629
d3b484f
f233294
20a3dbd
324714a
c4d9f74
38ef42d
eb14402
729b8ba
aca67b9
63c5905
518cd6e
aa2072e
301dc22
0b99b85
375895a
1d7da8d
f63ed66
af8b8a2
248d53a
8933245
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1628,7 +1628,14 @@ def _combine(self, applied, shortcut=False): | |
if shortcut: | ||
combined = self._concat_shortcut(applied, dim, positions) | ||
else: | ||
combined = concat(applied, dim) | ||
combined = concat( | ||
applied, | ||
dim, | ||
data_vars="all", | ||
coords="different", | ||
compat="equals", | ||
join="outer", | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hard-coded these to the old defaults since there is no way for the user to set them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with this approach. These options result in confusing groupby behaviour (#2145) but we can tackle that later |
||
combined = _maybe_reorder(combined, dim, positions, N=self.group1d.size) | ||
|
||
if isinstance(combined, type(self._obj)): | ||
|
@@ -1789,7 +1796,14 @@ def _combine(self, applied): | |
"""Recombine the applied objects like the original.""" | ||
applied_example, applied = peek_at(applied) | ||
dim, positions = self._infer_concat_args(applied_example) | ||
combined = concat(applied, dim) | ||
combined = concat( | ||
applied, | ||
dim, | ||
data_vars="all", | ||
coords="different", | ||
compat="equals", | ||
join="outer", | ||
) | ||
combined = _maybe_reorder(combined, dim, positions, N=self.group1d.size) | ||
# assign coord when the applied function does not return that coord | ||
if dim not in applied_example.dims: | ||
|
Uh oh!
There was an error while loading. Please reload this page.