Skip to content

Fix setuptools deprecation warnings #10300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix setuptools deprecation warnings #10300

wants to merge 2 commits into from

Conversation

gcaria
Copy link
Contributor

@gcaria gcaria commented May 9, 2025

@max-sixty max-sixty added the plan to merge Final call for comments label May 9, 2025
max-sixty
max-sixty reviewed May 9, 2025
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top stuff is great (can merge that now if you prefer), I think we can be more standard for the setuptools work

pyproject.toml
include-package-data = false

[tool.setuptools.package-data]
"*" = ["*.py"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need something like this:

[tool.setuptools.packages.find]
include = ["xarray*"]

...since that change will preclude *.pyi files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setuptools deprecation warnings
2 participants
@gcaria @max-sixty