Skip to content

Group decoding options into single argument #10429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Jun 18, 2025

Split out from #10422 for easier review.

Example Usage:

# simple call, use coder default options
ds = xr.open_dataset("test.nc", engine="netcdf4") # simple call
# define once, use many , these should be imported from the backend 
coder_opts = NetCDF4CoderOptions(decode_times=False, mask_and_scale=False)
# engine could also be the `BackendEntryPoint`
ds = xr.open_dataset("test.nc", engine="netcdf4", coder_opts=coder_opts)
# still works
ds = xr.open_dataset("test.nc", engine="netcdf4", decode_times=True)

@github-actions github-actions bot added topic-backends topic-documentation topic-CF conventions topic-zarr Related to zarr storage library CI Continuous Integration tools dependencies Pull requests that update a dependency file io labels Jun 18, 2025
@kmuehlbauer kmuehlbauer force-pushed the coder_kwargs_dataclass branch from 3e69f46 to da552d4 Compare June 18, 2025 10:02
@kmuehlbauer kmuehlbauer marked this pull request as ready for review June 18, 2025 13:37
@kmuehlbauer
Copy link
Contributor Author

OK, it looks as it should work the way @shoyer suggested in #4490. This should be complete enough for a first round of review.

I've tried to address docstrings/docs, but I'm happy to rework those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file io topic-backends topic-CF conventions topic-documentation topic-zarr Related to zarr storage library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group together decoding options into a single argument
1 participant