fix: pd.Series in pandas>=3 does not preserve object dtype metadata #10564
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta [test-upstream]
github-actions
bot
added
topic-indexing
topic-arrays
|
This seems like an upstream bug. Can you open an issue there please? |
3 tasks
|
Done! |
…o ig/fix_string_dtype
… ig/fix_series_cast
Co-authored-by: Deepak Cherian <[email protected]>
…o ig/fix_string_dtype
Co-authored-by: Deepak Cherian <[email protected]>
for more information, see https://pre-commit.ci
4 tasks
dcherian
reviewed
Jul 29, 2025
| @@ -216,7 +217,16 @@ def _possibly_convert_objects(values): | |||
| * pd.Timedelta | |||
| """ | |||
| as_series = pd.Series(values.ravel(), copy=False) | |||
| # For why we need this behavior: https://github.com/pandas-dev/pandas/issues/61938 | |||
There was a problem hiding this comment.
let's add a little more please "pandas will convert to str if possible; preserve object dtype metadata in all other cases"
we should update the docstring to say strings too.
dcherian
reviewed
Jul 29, 2025
| result = np.asarray(as_series).reshape(values.shape) | ||
| if ( |
There was a problem hiding this comment.
Can we move this after the writable bit below instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only opening this here ATM to see that CI runs through. The diff is otherwise as advertised in #10559 (comment)
whats-new.rstapi.rst