Loop from sniffio #780
Open
Loop from sniffio #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like Github is deprecating macos_x86? |
Korijn
reviewed
Nov 25, 2025
| self._UNRESOLVED.add(self) | ||
|
|
||
| # we only care about call_soon_threadsafe, but clearer to just have a loop object | ||
| self._loop = _loop or get_running_loop() |
Collaborator
There was a problem hiding this comment.
I am a little worried about the overhead of instantiating a GPUPromise though :o it seems like a bunch of time-consuming work on a potentially hot code path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of pygfx/rendercanvas#151, so that loop detection is fully automatic, via sniffio.
This only depends on pygfx/rendercanvas#151 for code that uses
.then(). So if we assume no user is usingrequest_adapter(...loop=loop), we can safely merge this :)