Skip to content

Fix codec errors when streaming proc output #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scootermon
Copy link

While working with fancy unicode characters I noticed that every now and then my output is messed up like this:

 ╭────────────────────────────────── overview ──────────────────────────────────╮
│ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━┓ │
│ ┃ Test Name                        ┃ Status      ┃                Duration ┃ │
│ ┡━━━━━━━━━━━━━━━━━���━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━┩ │
│ │ smoke                            │ OK          │          0:00:00.094022 │ │

Looking into it I realized that this is caused by the incorrect handling of partial reads from the proc output.
This PR fixes the issue by making use of the built-in IncrementalDecoder - a perfect fit for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant