Explicitly re-export names from top-level package using __all__
#981
+57
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was also going to open a PR for this. I'd move the |
This avoids the re-exports from being flagged as errors when a project that uses Invoke is checked using `mypy --no-implicit-reexport`. It also obsoletes all flake8 suppressions in `__init__.py`.
mthuurne
force-pushed
the
explicit-reexport
branch
from
14a7b3c to
ac3a8ba
Compare
In PEP8 style it should be placed above regular imports. I don't know if Invoke follows PEP8, but it seemed like a safe starting point. I don't mind moving it if a maintainer requests it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the re-exports from being flagged as errors when a project that uses Invoke is checked using
mypy --no-implicit-reexport.It also obsoletes all flake8 suppressions in
__init__.py.I assumed the following names should be re-exported:
__init__.pyitselfcontext.Contextandrunners.ResultI assumed the following names should not be re-exported:
typing.Anyandtyping.Optional