Update for changes in semantikon
#754
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URIs are not inherited, so add them. And the undesirable side effect of inheriting restrictions has been resolved upstream, so adapt/remove those tests. Signed-off-by: liamhuber <[email protected]>
To explicitly re-state URIs since they are no longer inherited with `derived_from`. And to update expectations around how requirements (don't!) propagate Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
This release doesn't exist yet, but this commit is compatible with the HEAD of semantikon right now, so let's look forward. Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
liamhuber
force-pushed
the
update_semantikon
branch
from
d6845c7 to
116c5c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pyiron/semantikon#266, inheritance of
uri=is removed whenderived_from=, and the bug of inheritingrestrictions=on connections is resolved. Here I make the small adjustments necessary to stay up-to-date with that.Pending the next
semantikonrelease.