Skip to content

User guide updates bpm panel #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 19, 2025
Merged

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Aug 7, 2025

Adds a description of the BPM panel to the Beta-Beat-GUI section.

Requires #188 to be merged first and back into this branch (will then also reduce the number of files changed)

@JoschD JoschD self-assigned this Aug 7, 2025
@JoschD JoschD added Type: Documentation Improvements, updates and fixes to the documentation. Status: Blocked Cannot be worked on until something else happens (e.g. closing other issues). Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. labels Aug 7, 2025
@JoschD JoschD marked this pull request as draft August 7, 2025 15:02
@JoschD JoschD marked this pull request as ready for review August 19, 2025 09:33
@JoschD JoschD requested review from fsoubelet, jgray-19 and emaclean and removed request for fsoubelet August 19, 2025 09:33
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Little things here and there, nothing big. I think this is a good opportunity to discuss if we want to keep or remove some old / currently broken and potentially useless features.

Comment on lines +138 to +147
### Averages, Removal of Turns and Splitting Files

!!! warning "Broken Functionality"
These features [are currently broken][issue283] and we are considering whether they are actually needed.

It contains BPM names and corresponding threshold which identified a BPM as faulty.
The buttons on the top left side of the pane provide some features to handle the BPM data.

!!! note
- ++"Create Average"++ allows loading several data files too visualize their average repesentations on the same graph, which helps detecting differences or reducing noise.
- ++"Remove Turns"++ can be used to cut turns from the start or the end, to focus on a specified range of the data.
- ++"Split Files"++ splits the current BPM data file into N files, where N is specified in the dialog and the resulting files will have old-turns/N turns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to get the opinion of @emaclean. I'd rather have these disappears, as stated on the linked issue we can just do that, but another way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discuss on the linked issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it also impacts this PR so if it's a quick discussion we might settle it here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a long way to merge into the master branch ;)

@JoschD JoschD requested a review from fsoubelet August 19, 2025 14:13
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoschD JoschD merged commit 1db37e1 into user_guide_updates Aug 19, 2025
2 checks passed
@JoschD JoschD deleted the user_guide_updates_bpm_panel branch August 19, 2025 14:51
@JoschD JoschD removed the Status: Blocked Cannot be worked on until something else happens (e.g. closing other issues). label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Type: Documentation Improvements, updates and fixes to the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants