Use reversed() for reverse iteration instead of in-place list reversal (#10547)

Author: vil02

pylint/checkers/classes/class_checker.py

@@ -1933,8 +1933,7 @@ def _check_protected_attribute_access(
         outer_klass = klass
         callee = node.expr.as_string()
         parents_callee = callee.split(".")
-        parents_callee.reverse()
-        for callee in parents_callee:
+        for callee in reversed(parents_callee):
             if not outer_klass or callee != outer_klass.name:
                 inside_klass = False
                 break

pylint/pyreverse/utils.py

@@ -47,9 +47,7 @@ def get_default_options() -> list[str]:
 
 def insert_default_options() -> None:
     """Insert default options to sys.argv."""
-    options = get_default_options()
-    options.reverse()
-    for arg in options:
+    for arg in reversed(get_default_options()):
         sys.argv.insert(1, arg)
 
 

pylint/utils/utils.py

@@ -112,8 +112,7 @@ def get_module_and_frameid(node: nodes.NodeNG) -> tuple[str, str]:
             frame = frame.parent.frame()
         except AttributeError:
             break
-    obj.reverse()
-    return module, ".".join(obj)
+    return module, ".".join(reversed(obj))
 
 
 def get_rst_title(title: str, character: str) -> str: