Skip to content

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added this to the 4.0.0 milestone Sep 23, 2025
@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Sep 23, 2025
@jacobtylerwalls
Copy link
Member Author

@zenlyj would you be up for fixing test failures here relating to the new astroid constraint? 🙏

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (77a2b07) to head (0f8e2e5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10585   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         176      176           
  Lines       19471    19471           
=======================================
  Hits        18679    18679           
  Misses        792      792           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on astroid:
The following messages are now emitted:

  1. useless-suppression:
    Useless suppression of 'unsubscriptable-object'
    https://github.com/pylint-dev/astroid/blob/97f48374e259cb46957d80c0f85ed71f6157b9ae/astroid/interpreter/_import/util.py#L86

The following messages are no longer emitted:

  1. suppressed-message:
    Suppressed 'unsubscriptable-object' (from line 86)
    https://github.com/pylint-dev/astroid/blob/97f48374e259cb46957d80c0f85ed71f6157b9ae/astroid/interpreter/_import/util.py#L87

Effect on home-assistant:
The following messages are no longer emitted:

  1. not-callable:
    delay_cancel is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/template/trigger.py#L87
  2. not-callable:
    delay_cancel is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/template/trigger.py#L165
  3. not-callable:
    remove is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/saj/sensor.py#L175
  4. not-callable:
    listener is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/airgradient/sensor.py#L257
  5. not-callable:
    unsub_pending is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/google_assistant/report_state.py#L203
  6. unsubscriptable-object:
    Value 'err.exceptions' is unsubscriptable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/mcp/coordinator.py#L56
  7. not-callable:
    self.async_extra_update is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/samsungtv/coordinator.py#L63
  8. unsubscriptable-object:
    Value 'eg.exceptions' is unsubscriptable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/ring/coordinator.py#L123
  9. not-callable:
    remove is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/duckdns/__init__.py#L150
  10. not-callable:
    self.new_home_callback is not callable
    https://github.com/home-assistant/core/blob/3c542b8d43b5cb331774c639711e8004b2727463/homeassistant/components/point/coordinator.py#L46

Effect on black:
The following messages are no longer emitted:

  1. not-callable:
    visitf is not callable
    https://github.com/psf/black/blob/4a8e6b789bbd18c0455d74bbec8d957e824eb3bf/src/black/nodes.py#L173

Effect on pytest:
The following messages are now emitted:

  1. missing-raises-doc:
    "Skipped" not documented as being raised
    https://github.com/pytest-dev/pytest/blob/958981cab1dc568de4e3a30a46c526ffd7067658/src/_pytest/outcomes.py#L199

The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'pypy_version_info' is unsubscriptable
    https://github.com/pytest-dev/pytest/blob/958981cab1dc568de4e3a30a46c526ffd7067658/src/_pytest/terminal.py#L838
  2. unsubscriptable-object:
    Value 'pypy_version_info' is unsubscriptable
    https://github.com/pytest-dev/pytest/blob/958981cab1dc568de4e3a30a46c526ffd7067658/src/_pytest/terminal.py#L839

Effect on django:
The following messages are no longer emitted:

  1. not-a-mapping:
    Non-mapping value cls._overridden_settings is used in a mapping context
    https://github.com/django/django/blob/6fe96639baf656db166997096bddec0f5c76fc65/django/test/testcases.py#L222
  2. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/6fe96639baf656db166997096bddec0f5c76fc65/django/test/testcases.py#L1227
  3. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/6fe96639baf656db166997096bddec0f5c76fc65/django/test/testcases.py#L1430
  4. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/6fe96639baf656db166997096bddec0f5c76fc65/django/test/testcases.py#L1484

Effect on pandas:
The following messages are no longer emitted:

  1. not-callable:
    memory_usage is not callable
    https://github.com/pandas-dev/pandas/blob/f6fa9b679006d08fa99d8c2b6dbd834ec60875d6/pandas/core/base.py#L131

Effect on sentry:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/utils/committers.py#L357
  2. no-member:
    Instance of 'dict' has no 'get_many' member
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/services/nodestore/base.py#L286
  3. no-member:
    Instance of 'dict' has no 'set_many' member
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/services/nodestore/base.py#L296
  4. no-member:
    Instance of 'dict' has no 'delete' member
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/services/nodestore/base.py#L300
  5. no-member:
    Instance of 'dict' has no 'delete_many' member
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/services/nodestore/base.py#L304
  6. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/issues/ownership/grammar.py#L140
  7. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/aef8539f20f1f3681922be6ddcec11afb435dd60/src/sentry/issues/ownership/grammar.py#L141

This comment was generated for commit 0f8e2e5

@zenlyj
Copy link
Contributor

zenlyj commented Sep 23, 2025

@jacobtylerwalls sure thing, let me look into this one

@Pierre-Sassoulas
Copy link
Member

The primer is looking very good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants