Skip to content

Minor fixes to modelbuilder class #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor fixes to modelbuilder class #452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db49aa7
set is_fitted = True after .fit call
butterman0 Apr 9, 2025
edec539
is_fitted = True when trained model is loaded
butterman0 Apr 9, 2025
93c5ed6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pymc_extras/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ def load(cls, fname: str):
sampler_config=json.loads(idata.attrs["sampler_config"]),
)
model.idata = idata
model.is_fitted_ = True
dataset = idata.fit_data.to_dataframe()
X = dataset.drop(columns=[model.output_var])
y = dataset[model.output_var]
Expand Down Expand Up @@ -524,6 +525,8 @@ def fit(
)
self.idata.add_groups(fit_data=combined_data.to_xarray()) # type: ignore

self.is_fitted_ = True

return self.idata # type: ignore

def predict(
Expand Down