Fix: autoregressive params info #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmmh, there is a weird test failure on Windows, due to pytensor 🤔 |
|
Yes it's a pytensor level issue with the BLAS linker on the new windows VMs that github deployed a few weeks ago. We can ignore it as long as all other tests pass. |
jessegrabowski
requested changes
Sep 28, 2025
|
Done @jessegrabowski ! You can merge once tests pass |
jessegrabowski
approved these changes
Oct 1, 2025
tests/statespace/models/structural/components/test_autoregressive.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Grabowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoRegressiveComponent doesn't handle the
params_infocorrectly when there areobserved_state_namesandshare_states=True. This PR fixes it.Ready for review