-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow for pymc native samplers to resume sampling from ZarrTrace
#7687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucianopaz
wants to merge
13
commits into
pymc-devs:main
Choose a base branch
from
lucianopaz:zarr_continue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e5f0e5b
Make WithSamplingState generic
lucianopaz a211961
Disambiguate DEMetropolis tune and tune_target
lucianopaz fcba007
QuadPotential initial values were never supposed to be frozen
lucianopaz ce7bc5d
WithSamplingState now checks for dataclass compatibility before setti…
lucianopaz 8e4d440
Refactor ZarrTrace to write directly to warmup and final groups
lucianopaz e1bcdd1
Add mcmc_point to ZarrTrace.root._sampling_state
lucianopaz c3e62dc
Add ZarrTrace.resize
lucianopaz 2a9f318
Add ZarrTrace.from_store
lucianopaz 5003508
Add ZarrTrace compatibility checks
lucianopaz 5b69bb8
Resume sampling from existing ZarrTrace
lucianopaz 83ecf8d
Update progressbar managers with existing fit results from ZarrTrace
lucianopaz 134b40b
Fix typing issue
lucianopaz 5259ae2
Fix compatibility test error message
lucianopaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,6 +201,42 @@ | |
def point(self, idx: int) -> dict[str, np.ndarray]: | ||
return self._chain.get_draws_at(idx, [v.name for v in self._chain.variables.values()]) | ||
|
||
def completed_draws_and_divergences(self, chain_specific: bool = True) -> tuple[int, int]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question why do we have special handling for divergences, instead of being sampler agnostic? |
||
"""Get number of completed draws and divergences in the trace. | ||
|
||
This is a helper function to start the ProgressBarManager when resuming sampling | ||
from an existing trace. | ||
|
||
Parameters | ||
---------- | ||
chain_specific : bool | ||
If ``True``, only the completed draws and divergences on the current chain | ||
are returned. If ``False``, the draws and divergences across all chains are | ||
returned. WARNING: many BaseTrace backends are not aware of the information | ||
stored in other chains and will raise a ``ValueError`` if passed ``False``. | ||
|
||
Returns | ||
------- | ||
draws : int | ||
Number of draws in the current chain or across all chains. | ||
divergences : int | ||
Number of divergences in the current chain or across all chains. | ||
""" | ||
if not chain_specific: | ||
raise ValueError( | ||
"NDArray traces are not aware of the number of draws and divergences " | ||
"recorded in other chains. Please call this method using " | ||
"chain_specific=True" | ||
) | ||
try: | ||
divergent_draws = self.get_sampler_stats("divergence") | ||
if divergent_draws.ndim > 1: | ||
divergent_draws = divergent_draws.sum(axis=-1) | ||
divergences = sum(divergent_draws > 0) | ||
except KeyError: | ||
divergences = 0 | ||
return len(self), divergences | ||
|
||
|
||
def make_runmeta_and_point_fn( | ||
*, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just
InitializedTrace
? Seems a little verbose!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine to me, it's an internal thing