Skip to content

Conversation

@louismagowan
Copy link
Contributor

@louismagowan louismagowan commented Nov 2, 2025

Closes #378


📚 Documentation preview 📚: https://causalpy--544.org.readthedocs.build/en/544/

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (81eb020) to head (3a8cec5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   95.59%   96.48%   +0.88%     
==========================================
  Files          29       29              
  Lines        2681     2703      +22     
==========================================
+ Hits         2563     2608      +45     
+ Misses        118       95      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@louismagowan louismagowan changed the title Lm type hints Add Type Hints to simulate_data.py Nov 2, 2025
@louismagowan
Copy link
Contributor Author

@drbenvincent codecov failure seems irrelevant for a PR that just adds type hints right? These were pre-existing issues right, or am I missing something?

@louismagowan
Copy link
Contributor Author

pre-commit.ci autofix

@louismagowan
Copy link
Contributor Author

louismagowan commented Nov 8, 2025

@drbenvincent codecov failure seems irrelevant for a PR that just adds type hints right? These were pre-existing issues right, or am I missing something?

Hi @drbenvincent I added a test on the functions that were causing CodeCov to fail - but I am certain this was a pre-existing issue and nothing related to my PR 🤷

Hopefully this is good to go now though 😁

@drbenvincent
Copy link
Collaborator

drbenvincent commented Nov 8, 2025

Sorry shot the delay on this - it's been a manic week. I'll try to review this asap.

Agree on the code coverage thing, I'll try to deal with that separately. Cool, will take a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add/improve type hints for functions in simulate_data.py

2 participants