-
Notifications
You must be signed in to change notification settings - Fork 85
Add Type Hints to simulate_data.py
#544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 95.59% 96.48% +0.88%
==========================================
Files 29 29
Lines 2681 2703 +22
==========================================
+ Hits 2563 2608 +45
+ Misses 118 95 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b22a00 to
f4062be
Compare
|
@drbenvincent codecov failure seems irrelevant for a PR that just adds type hints right? These were pre-existing issues right, or am I missing something? |
|
pre-commit.ci autofix |
Hi @drbenvincent I added a test on the functions that were causing CodeCov to fail - but I am certain this was a pre-existing issue and nothing related to my PR 🤷 Hopefully this is good to go now though 😁 |
|
Sorry shot the delay on this - it's been a manic week. I'll try to review this asap.
|
Closes #378
📚 Documentation preview 📚: https://causalpy--544.org.readthedocs.build/en/544/