Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using unrar to 7z #11524

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

tonyg
Copy link

@tonyg tonyg commented Oct 20, 2023

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

This little patch experimentally replaces use of unrar (problematic in e.g. #10777) with 7z, which is actually pretty close to drop-in compatible, it seems.

@medariox
Copy link
Contributor

Hey! Thanks for the PR. I don't understand what PySocks is required for. Could you clarify?

@tonyg
Copy link
Author

tonyg commented Nov 17, 2023

Oops. Sorry, that commit snuck in there. PySocks is required to do anything with a socks proxy at all (AFAICT). I needed the unrar-to-7z thing just to get it to run at all in docker, and then the PySocks thing was notionally separate (though I don't think I understand how socks could ever have worked if PySocks wasn't present!). From the contribution guidelines, I imagine you'd prefer me to redo the branch keeping the two changes separate; let me know if I need to do that or if you're happy to just take it as is (which would be easier for me at least!). Thanks for the software!

@p0psicles
Copy link
Contributor

If it's experimental and mainly added for arm. I'd prefer to have a separate module, that we can load on arm devices. Or feature flag. Would you be okay looking into such a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants