Fix bugs in rss client #11586
Open
Fix bugs in rss client #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into develop-rss
The previous test compared the xml as a string to an expected string. This worked occasionally because the xml writer will sometimes place attributes in a random order. Also a bunch of formatting changes while I tried to eliminate warnings
…into develop-rss
Change import from ET to ElemTree and change whitespace location in expected string to satisfy Flake8. This doesn't affect the test, but unclogs the test output a little. Recursive test fails on assertion rather than returning bool to bubble up through the nested generators. Strip newlines from expected string before parsing in ElementTree
Strips all non-ascii characters when writing the xml document. Writes a new xml document if the existing document is empty or just whitespace
|
Thanks for the PR! Could you please rebase it onto the current develop branch? |
|
This is when I have to admit that other than your standard push/pull I know very little about how git works. Attempting to rebase onto origin:develop resulted in a huge amount of conflicts in files I didn't modify. And I'm a bit unsure about how to handle that. |
Some episode descriptions contain non-ascii characters, and this can cause errors. This commit simply ignores those characters, which is safe because hashes and urls must be ascii by definition.
qBittorrent (and possibly others) do not support xml with ascii encoding, so this commit forces utf-8/unicode in ElementTree and when reading/writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strips all non-ascii characters when writing the xml document.
Writes a new xml document if the existing document is empty or just whitespace