Skip to content

pylint complained about unchanged code being invalid. #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
Dec 7, 2025
Merged

pylint complained about unchanged code being invalid. #2821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions examples/package_test_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,31 +103,31 @@ def callback_new_connection(self) -> ModbusProtocol:
return new_stub


test_port = 5004
TEST_PORT = 5004

class ClientTester: # pylint: disable=too-few-public-methods
"""Main program."""

def __init__(self, comm: CommType):
"""Initialize runtime tester."""
global test_port # pylint: disable=global-statement
global TEST_PORT # pylint: disable=global-statement
self.comm = comm
host = NULLMODEM_HOST
self.client: modbusClient.AsyncModbusTcpClient | modbusClient.AsyncModbusSerialClient
if comm == CommType.TCP:
self.client = modbusClient.AsyncModbusTcpClient(
host,
port=test_port,
port=TEST_PORT,
)
else: # if comm == CommType.SERIAL:
host = f"{NULLMODEM_HOST}:{test_port}"
host = f"{NULLMODEM_HOST}:{TEST_PORT}"
self.client = modbusClient.AsyncModbusSerialClient(
host,
)
server_params = self.client.ctx.comm_params.copy()
server_params.source_address = (host, test_port)
server_params.source_address = (host, TEST_PORT)
self.stub = TransportStub(server_params, True, simulate_server)
test_port += 1
TEST_PORT += 1


async def run(self):
Expand All @@ -148,7 +148,7 @@ class ServerTester: # pylint: disable=too-few-public-methods

def __init__(self, comm: CommType):
"""Initialize runtime tester."""
global test_port # pylint: disable=global-statement
global TEST_PORT # pylint: disable=global-statement
self.comm = comm
self.store = ModbusDeviceContext(
di=ModbusSequentialDataBlock(0, [17] * 100),
Expand All @@ -166,19 +166,19 @@ def __init__(self, comm: CommType):
self.context,
framer=FramerType.SOCKET,
identity=self.identity,
address=(NULLMODEM_HOST, test_port),
address=(NULLMODEM_HOST, TEST_PORT),
)
else: # if comm == CommType.SERIAL:
self.server = modbusServer.ModbusSerialServer(
self.context,
framer=FramerType.SOCKET,
identity=self.identity,
port=f"{NULLMODEM_HOST}:{test_port}",
port=f"{NULLMODEM_HOST}:{TEST_PORT}",
)
client_params = self.server.comm_params.copy()
client_params.timeout_connect = 1.0
self.stub = TransportStub(client_params, False, simulate_client)
test_port += 1
TEST_PORT += 1


async def run(self):
Expand Down