Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: pipx run --inspect script.py #1457

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ftnext
Copy link

@ftnext ftnext commented Jun 18, 2024

Resolve #1456

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Test plan

Tested by running

# command(s) to exercise these changes



@mock.patch("pipx.commands.run.exec_app")
def test_run_inspect(exec_app, tmp_path):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is difficult to use execvpe_mock in this (python -i) case.

I will appreciate your comment about this test implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be quite difficult to actually test this. I would be satisfied if this just mock out the actual process invocation and just chheck the right flags are passed to the child process.

@uranusjr
Copy link
Member

I wonder if --inspect is the right name (my intuition is --interactive). Since Python just uses -i, maybe we should also only have that to avoid confusion?

@chrysle chrysle added the awaiting response Awaiting re-engagement by contributor label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting re-engagement by contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: inspect interactively after pipx run script.py like python -i script.py
3 participants