Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hack to handle VS2015-Express #4884

Closed
wants to merge 1 commit into from

Conversation

refack
Copy link

@refack refack commented Mar 12, 2025

Summary of changes

Remove a 10 year old hack needed to acomodated VS2015 Express that was introduced in bafe9fb

Pull Request Checklist

@refack
Copy link
Author

refack commented Mar 12, 2025

I wanted to gauge the mood WRT this change, so I posted this as a draft.
For me the current logic fails since I trimmed my build toolset and removed the x86 and arm* hosts since my machine is x64.
If there are no objection on principal, I'll try to come up with a test.

@abravalheri
Copy link
Contributor

Hi @refack , please note that any changes in the _distutils folder should be directed to the pypa/distutils repository.

I would also recommend adding some text with the motivation behind the change (e.g. what does it improve? What does it make possible?...) and some assessment regarding the likelihood there is people out there relying on the old implementation and if it would break their setups.

@refack
Copy link
Author

refack commented Mar 13, 2025

@abravalheri thank you. Noted.

@refack refack closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants