Refs/heads/hotfix consistdraw #618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
took some work but got to a point where the ensemble gaussian draw is consistent across OSs. Previously, the eigen solver was giving (sometimes very different) eigen vectors (if the matrix is near singular) which leads different projection matrices and ultimately, different ensembles. Ended up moving to cholesky factorization instead bc it seems to be consistent across platforms. But if the covariance matrix is singular, #badtimes...added a new set of model + pest files for the case that is giving inconsistent eigen-based draws and there is now a strict check of realized values across platforms. (also messed around with the CI to get the coveralls notebook test issue sidestepped for now)