Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terms of Service rollout #17629

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Terms of Service rollout #17629

wants to merge 25 commits into from
+1,156 −167

Conversation

ewdurbin
Copy link
Member

Tooling, blog, and docs around Terms of Use -> Terms of Service rollout.

Needs to be coordinated with psf/policies#34

@ewdurbin ewdurbin requested a review from a team as a code owner February 20, 2025 18:47
@ewdurbin ewdurbin mentioned this pull request Feb 20, 2025
Open
miketheman
miketheman reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the code/tests just yet, this was a first pass on content

di
di reviewed Feb 21, 2025
View reviewed changes
di
di approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the TBDs that need filled in.

miketheman
miketheman requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got through almost everything - lots of inline comments, suggestions, and questions. Let me know if anything isn't clear!

@ewdurbin ewdurbin requested a review from miketheman February 24, 2025 22:10
@ewdurbin
Copy link
Member Author

For initial deployment, I've set the same values on test.pypi.org and pypi.org:

TERMS_REVISION=2024-02-25
TERMS_NOTIFICATION_BATCH_SIZE=0

After rollout of this PR and psf/policies#34, I'll start upping TERMS_NOTIFICATION_BATCH_SIZE and monitor task execution time and SES metrics to ensure that the main task notify_users_of_tos_update is completing within ~30s to keep from overlapping with the next run and that we aren't tanking our reputation metrics. We have 212,275 emails to send as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

@miketheman miketheman Awaiting requested review from miketheman

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewdurbin @di @miketheman