feat: unverify expired domains #18055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With domain status checking now in place, add a task to unverify any email address that is in one of the statuses considered "expired". Add an Observation on the User, as well updates the unverify reason. Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added
the
admin
di
reviewed
May 1, 2025
There was a problem hiding this comment.
I'm not sure I see the point in doing this as-is: an attacker can still just register the expired domain, issue a password reset request to the un-verified email, and gain access to the account.
I think instead we probably need to either prevents sending password resets to unverified emails, add a different verification state that prevents sending reset requests to these emails (an 'expired' status?) or just remove the email from the account entirely.
|
unverify + freeze? |
|
That would work but would probably be the most support-intensive option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With domain status checking now in place, add a task to unverify any email address that is in one of the statuses considered "expired".
Add an Observation on the User, as well updates the unverify reason.