Skip to content

Switch from pyqrcode to pyqrcode-binary #18066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

di
Copy link
Member

@di di commented May 1, 2025

Towards #18058.

This changes our dependency from https://pypi.org/project/PyQRCode/ (last release in 2016, no wheels available) to https://pypi.org/project/pyqrcode-binary/, which mirrors binary builds for each release of the original dependency.

@di di requested a review from a team as a code owner May 1, 2025 16:18
@di di enabled auto-merge (squash) May 1, 2025 16:25
@miketheman
Copy link
Member

Curious - did you check to see if the more maintained, pure Python options of qrcode or segno are better?

@di
Copy link
Member Author

di commented May 1, 2025

Better how? I think the current library is working fine for our needs, it just needs wheels.

@miketheman
Copy link
Member

Better, as in reducing the amount of compiled binaries necessary to audit in the event of some problem.

@di
Copy link
Member Author

di commented May 1, 2025

To be clear, pyqrcode-binary has pure Python wheels, there is no native code or binaries. So the tradeoff here is one wheel based on a dependency we already use vs. one wheel for a new dependency we'd have to adopt.

@di di merged commit ec1f518 into pypi:main May 1, 2025
20 checks passed
@di di deleted the change-pyqrcode-dep branch May 1, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants