Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve delete release warning (closes #4737) #4815

Merged
merged 8 commits into from
Oct 28, 2018
Merged

Conversation

Cheukting
Copy link
Contributor

@Cheukting Cheukting commented Oct 6, 2018

Adding warning when user try to delete a release " You will not be able to re-upload a new distribution of the same type with the same version number." also suggest "Consider making a new release or a post release instead."

closes #4737

@di
Copy link
Member

di commented Oct 8, 2018

Thanks @Cheukting! I don't think testing is needed here, since this is just a change to the HTML template. Let me know when you're ready for a review.

@Cheukting
Copy link
Contributor Author

@di thanks for your comment. Yes I think it is simple enough. I was thinking I have to run the image and see how it would look like before having it reviewed. However I am encountering problem with running the image locally on my laptop. Wouldn't mind if you or your team review it now and give some comments. I would try to get some help later this month when I join the Sprint in London to make it work eventually.

@Cheukting Cheukting changed the title [WIP] Improve delete release warning (closes #4737) Improve delete release warning (closes #4737) Oct 13, 2018
Deleting will irreversibly delete this release
Deleting will irreversibly delete this release.
You will not be able to re-upload a new distribution of the same type with the same version number.
Consider making a new release or a post release instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shevelevs
Copy link

I think this PR doesn't actually address the issue. Instead it changes the message that you see on the release page, and only when there are no files. It should be done in a different template (templates/manage_base.html)

@shevelevs
Copy link

Here's what the result of this change looks like:
screen shot 2018-10-27 at 11 39 01 am

@Cheukting
Copy link
Contributor Author

Thanks @shevelves, will fix it tomorrow

@di
Copy link
Member

di commented Oct 27, 2018

@shevelevs is correct, I think this should be in both places (in the pop-up modal, and in the warning box where it currently is).

@shevelevs
Copy link

Just to make it clear, this change still shows the improved warning on the main release page only when release has no associated files

@di di merged commit d6f5ccb into pypi:master Oct 28, 2018
@di
Copy link
Member

di commented Oct 28, 2018

Thanks @Cheukting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform users that a deleted release cannot be re-uploaded
3 participants