-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve delete release warning (closes #4737) #4815
Conversation
Thanks @Cheukting! I don't think testing is needed here, since this is just a change to the HTML template. Let me know when you're ready for a review. |
@di thanks for your comment. Yes I think it is simple enough. I was thinking I have to run the image and see how it would look like before having it reviewed. However I am encountering problem with running the image locally on my laptop. Wouldn't mind if you or your team review it now and give some comments. I would try to get some help later this month when I join the Sprint in London to make it work eventually. |
Deleting will irreversibly delete this release | ||
Deleting will irreversibly delete this release. | ||
You will not be able to re-upload a new distribution of the same type with the same version number. | ||
Consider making a new release or a post release instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to https://www.python.org/dev/peps/pep-0440/#post-releases on "post release"?
I think this PR doesn't actually address the issue. Instead it changes the message that you see on the release page, and only when there are no files. It should be done in a different template (templates/manage_base.html) |
Thanks @shevelves, will fix it tomorrow |
@shevelevs is correct, I think this should be in both places (in the pop-up modal, and in the warning box where it currently is). |
Co-Authored-By: Cheukting <[email protected]>
Co-Authored-By: Cheukting <[email protected]>
Just to make it clear, this change still shows the improved warning on the main release page only when release has no associated files |
Thanks @Cheukting! |
Adding warning when user try to delete a release " You will not be able to re-upload a new distribution of the same type with the same version number." also suggest "Consider making a new release or a post release instead."
closes #4737