Skip to content

refactor: Rewrite pyRevit configurations #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: develop
Choose a base branch
from
Draft

refactor: Rewrite pyRevit configurations #2482

wants to merge 53 commits into from

Conversation

@dosymep
Copy link
Member

@dosymep dosymep commented Dec 18, 2024

  • added config abstraction
  • added config overrides (need testing and design the logic of work)
  • replace ini lib to ini-parser
  • added json configuration
  • added yaml configuration (doesn't work I need to figure out the parser library)

I think in general a start has been made, it remains to rewrite the logic of the config in python

@dosymep dosymep added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Enhancement Enhancement request [class->Improved #{number}: {title}] Backward Compatibility Backward Compatibility Issue with Older Revit Versions DotNet API Issues related to pyRevitLabs libraries [subsystem] API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}] labels Dec 18, 2024
@dosymep dosymep added this to the post pyRevit 5 RC milestone Dec 18, 2024
@dosymep dosymep linked an issue Dec 18, 2024 that may be closed by this pull request
[Bug]: manage access to pyrevit-config.ini at startup #2463
Closed
5 tasks
@dosymep dosymep marked this pull request as ready for review December 18, 2024 11:21
@dosymep dosymep assigned dosymep and unassigned sanzoghenzo Dec 18, 2024
@dosymep dosymep marked this pull request as draft December 18, 2024 11:23
@dosymep
Copy link
Member Author

dosymep commented Dec 18, 2024

@jmcouffin @sanzoghenzo how to trigger github action?

@jmcouffin
Copy link
Contributor

jmcouffin commented Dec 18, 2024

@jmcouffin @sanzoghenzo how to trigger github action?

image

@jmcouffin
Copy link
Contributor

jmcouffin commented Dec 18, 2024

I just launched it.
15min+ to go

I won't be able to review just now, best I can do is install the wip that will be created

sanzoghenzo
sanzoghenzo requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@sanzoghenzo sanzoghenzo left a comment •
edited by jmcouffin
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @dosymep !

I didn't run the code, only skimmed through, and only found some grammar to fix (ShouldThrows -> ShouldThrow).

Do you think it would be worth creating separate repo(s) and nuget package(s) for this feature (just to start the transition to a better code structure)?

@dosymep
Copy link
Member Author

dosymep commented Dec 20, 2024 •
edited
Loading

creating separate repo(s) and nuget package(s)

it won't work, we have dependencies on this repo, at the moment I still don't know how to do this :(

@sanzoghenzo sanzoghenzo mentioned this pull request Jan 12, 2025
Closed
5 tasks
@jmcouffin jmcouffin changed the title Rewrite pyRevit configurations refactor: Rewrite pyRevit configurations Feb 1, 2025
@dosymep
Merge branch 'develop' into features/configuration
bb3408d 
# Conflicts:
#	bin/netcore/pyRevitLabs.Emojis.dll
#	bin/netfx/pyRevitLabs.Emojis.dll
#	dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitClones.cs
#	dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitConfig.cs
#	dev/pyRevitLabs/pyRevitLabs.PyRevit/PyRevitConfigs.cs
#	pyrevitlib/pyrevit/coreutils/configparser.py
@dosymep
remove build configurations tests
981668a
@dosymep
move configuration sections to dedicated folder
f964d2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanzoghenzo sanzoghenzo sanzoghenzo requested changes

@jmcouffin jmcouffin Awaiting requested review from jmcouffin

Requested changes must be addressed to merge this pull request.

Assignees

@dosymep dosymep

Labels

API Change Revit API change that breaks pyRevit [class->Upgraded #{number}: {title}] Backward Compatibility Backward Compatibility Issue with Older Revit Versions Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] DotNet API Issues related to pyRevitLabs libraries [subsystem] Enhancement Enhancement request [class->Improved #{number}: {title}] ODHack14

Projects

pyRevit Refactor
Status: In progress
pyRevit5
Status: In Progress

Milestone

post pyRevit 5 RC

Development

Successfully merging this pull request may close these issues.

[Bug]: manage access to pyrevit-config.ini at startup

4 participants

@dosymep @jmcouffin @sanzoghenzo