Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadBalancerSourceRanges #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

alexz75
Copy link

@alexz75 alexz75 commented Sep 29, 2022

Added loadBalancerSourceRanges into service to provide network level security

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ alexz75
❌ alexs-airo
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @alexz75! I'm terribly sorry for such a long delay in response – for some reason I simply missed the notification.

The PR looks good! There are a couple of notes from me:

  • A nit: it would be nice to describe the new option in README - please see my suggestion
  • Some CI checks fail: please take a look at our contribution guide:
    1. Versions need a bump – alas, you need to update versions manually in your branch
    2. We use helm-docs to generate the documentation

chart/pyroscope/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Anton Kolesnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants