fix: script tag now forces open-closed tag pair #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s where an empty div with a class is intended to not contain elements;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scripttag usually does not contain any contents, so (prior to this PR) it rendered with the closing anchor/>, but this causes issues when rendering the HTML. This update adds a function toSimpleElementthat returns if the render should include the separate closing tag.As of right now the only reason is if theThere are also instances when the user may intend for a tag to be empty (ex: <div class="someClass"></div>). This update also fixes these instances.tag_nameis"script", but this can now easily be expanded in the future.