Fix #2160 - Add m/py:progress events #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
force-pushed
the
py-progress
branch
from
1e98e39 to
7d08b65
Compare
WebReflection
force-pushed
the
py-progress
branch
from
7d08b65 to
b6aba53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes pyscript/pyscript#2160 by implementing tons of progress event, namely
py:progressandmpy:progressso that the bootstrap dance can easily provide some visual feedback around what's going on by simply adding an event listener on the page that listens topy:progress(ormpy:progress) custom events.All events, except those coming from miropip, have a
Loading ...start and aLoaded ...end whereLoading Pyodidewraps around all operations untilLoaded Pyodidedetail is provided.Events are triggered from both main thread and workers.