changed shiboken directory name to shibofen and modified cmakelists.txt in order. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed "shibofen" directory name to "shibokendir" to be more appeal
renamed: generator/shibofen/CMakeLists.txt -> generator/shibokendir/CMakeLists.txt
renamed: generator/shibofen/cppgenerator.cpp -> generator/shibokendir/cppgenerator.cpp
renamed: generator/shibofen/cppgenerator.h -> generator/shibokendir/cppgenerator.h
renamed: generator/shibofen/headergenerator.cpp -> generator/shibokendir/headergenerator.cpp
renamed: generator/shibofen/headergenerator.h -> generator/shibokendir/headergenerator.h
renamed: generator/shibofen/overloaddata.cpp -> generator/shibokendir/overloaddata.cpp
renamed: generator/shibofen/overloaddata.h -> generator/shibokendir/overloaddata.h
renamed: generator/shibofen/shibokengenerator.cpp -> generator/shibokendir/shibokengenerator.cpp
renamed: generator/shibofen/shibokengenerator.h -> generator/shibokendir/shibokengenerator.h
renamed: generator/shibofen/shibokennormalize.cpp -> generator/shibokendir/shibokennormalize.cpp
renamed: generator/shibofen/shibokennormalize_p.h -> generator/shibokendir/shibokennormalize_p.h
changed "shibofen" directory name to "shibokendir" to make it more
appealing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created shiboken binary and shiboken folder was conflicting, so i renamed shiboken folder to shibokendir and editted cmakelists.txt to make it work.
Note: this is the first time i am doing pull request, i am not a student at computer science or something, just wanted to say that my fix works
Note i just updated my pull request to be more appealing