Skip to content

Fix the pinned build-system version #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kurtmckee
Copy link
Contributor

Describe the changes

setuptools v45.x doesn't support pyproject.toml files.
v62.1.x and higher do, and continue to support Python 3.7.

Reproducer:

# Create a venv
python -m venv venv-demo
source venv-demo/bin/activate

# Install setuptools and build
python -m pip install setuptools==45.0.0 build

# Build the package using the already-installed setuptools
python -m build --no-isolation

This results in the following error:

ERROR Backend 'setuptools.build_meta' is not available.

Changing the reproducer to use setuptools 61.2.0 demonstrates that the issue is resolved.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing
  • For documentation changes: The Read the Docs preview builds and looks as expected

setuptools v45.x doesn't support `pyproject.toml` files.
v62.1.x and higher do, and continue to support Python 3.7.

Reproducer:

```
# Create a venv
python -m venv venv-demo
source venv-demo/bin/activate

# Install setuptools and build
python -m pip install setuptools==45.0.0 build

# Build the package using the already-installed setuptools
python -m build --no-isolation
```

This results in the following error:

```
ERROR Backend 'setuptools.build_meta' is not available.
```

Changing the reproducer to use setuptools 61.2.0
demonstrates that the issue is resolved.
@mrbean-bremen
Copy link
Member

Thanks, this looks sensible, as far as I can see!

I'm traveling right now, will have a closer look / merge next week when I have access to a computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants