Adapt to getfixturedefs change in pytest 8.1
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of this (private) function will change in the upcoming pytest 8.1 release: pytest-dev/pytest#11785 Additionally, the `iterparentnodeids` function is removed, so copy/pasting it for now. I verified that all tests pass when run against pytest main.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 95.58% 95.18% -0.41%
==========================================
Files 49 50 +1
Lines 1788 1826 +38
Branches 193 200 +7
==========================================
+ Hits 1709 1738 +29
- Misses 52 57 +5
- Partials 27 31 +4 ☔ View full report in Codecov by Sentry. |
youtux
previously approved these changes
Jan 21, 2024
|
Fixes #668 |
|
I got the pytest version check wrong, fixing it in #669 |
|
@youtux , thanks for the fix. Do you know when the fix will be released? |
|
I'll do a release later today |
This was referenced Mar 4, 2024
|
pytest-bdd 7.1.1 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of this (private) function will change in the upcoming pytest 8.1 release:
pytest-dev/pytest#11785
Additionally, the
iterparentnodeidsfunction is removed, so copy/pasting it for now.I verified that all tests pass when run against pytest main.