Type annotation test #605
Type annotation test #605
Conversation
src/pytestqt/qtbot.py
Outdated
| @@ -13,6 +14,11 @@ | |||
| CallbackCalledTwiceError, | |||
| ) | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from qtpy.QtWidgets import QWidget | |||
There was a problem hiding this comment.
Does qtpy provide useful types?
There was a problem hiding this comment.
I'm not sure we can provide useful types for Qt classes for now... as commented in #417 (comment), I would focus on typing non-Qt things for now and getting the infrastructure in place.
There was a problem hiding this comment.
Does
qtpyprovide useful types?
Qtpy provides all the expected classes and with some common API, mostly relying on conditional imports of the actual qt in your environment. This way I believe it would use whichever underlying qt that came from the testing matrix in tox.
There was a problem hiding this comment.
I'm not sure we can provide useful types for Qt classes for now... as commented in #417 (comment), I would focus on typing non-Qt things for now and getting the infrastructure in place.
Would the precommit check be sufficient infrastructure? That way it runs locally as well as CI. Or shall I look into a separate CI linting stage?
No description provided.