Skip to content

Applying technique from #773 to is_enabled property #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Applying technique from #773 to is_enabled property #802

wants to merge 1 commit into from

Conversation

pfuntner
Copy link

@pfuntner pfuntner commented Apr 3, 2025 •
edited
Loading

This applies the same technique from #773 to the is_running property of the SystemdService class of testinfra/modules/service.py to fix #801.

I tried following the steps from CONTRIBUTING.rst but got some errors from tox while installing timelib: tox-output.txt.

  • Are there prerequisites I'm missing? If so, can CONTRIBUTING.rst be improved?
  • The automated tests were successful. Are they sufficient?

Let me know if I can do anything to get this merged.

@pfuntner pfuntner mentioned this pull request Apr 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service is_enabled does not work with exit code 4
1 participant
@pfuntner