-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix skip bug in which if exception group has all skips it reported error instead of skip #13741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0380548
to
90fba0d
Compare
This PR also contains the commits from #13757, could you fix this please? Thanks! |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't think too much about this, just some comments from reading the PR.
9adef4b
to
2d37732
Compare
@bluetech Thanks for the review I fixed all the comments Summary of changes:
Note: checking if exceptions exist and its insides feels a bit hacky to me using open to suggestions, wasn't sure how much more energy should be spent on this since it's such a edge case scenario. i remember @bluetech mentioned flattening the exception group in #13650 maybe that is the way to go for better clarity and not having to explicitly check the insides of also so saw a suggestion for |
…d exceptions in teardown
Added handling for exception group with only skips inside of it to the reporter
fixes issue: #13537