Bugfix 14412 subtests timing - #14670
Open
marcelomarkus wants to merge 3 commits into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
marcelomarkus
force-pushed
the
bugfix-14412-subtests-timing
branch
from
July 2, 2026 01:00
78245f7 to
5f6d46e
Compare
Member
|
missing attributions |
marcelomarkus
force-pushed
the
bugfix-14412-subtests-timing
branch
from
August 13, 2026 11:27
85be6a4 to
9643247
Compare
Author
|
Updated the PR description with attributions (including AI co-author trailers and credits for @shimonenator) and checked the PR checklist. Thanks! |
…t_style=times (pytest-dev#14412) When console_output_style="times" is used with subtests, subtest timing information and parent test PASSED reports were displayed with incorrect/zero durations. This change includes subtest reports in terminal reporter aggregation and tracks reported durations by object identity rather than nodeid. Fixes pytest-dev#14412. Co-authored-by: Shimon Schwartz <shimonenator@gmail.com> Co-authored-by: Antigravity <antigravity@google.com>
marcelomarkus
force-pushed
the
bugfix-14412-subtests-timing
branch
from
August 13, 2026 11:39
9643247 to
672b551
Compare
…reported and add xdist test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14412.
When using
console_output_style="times"and running subtests, the timing information for subsequent subtests and the parent test'sPASSEDreport is displayed as0.000us(or similar tiny/incorrect durations).This occurs because:
"subtests ") are not included in the terminal reporter'sall_reportslist.nodeid. Since all subtests and the parent test share the samenodeid, once the first report (usually setup) is processed, thenodeidis marked as reported and subsequent reports are ignored.This PR fixes this by:
"subtests "reports in the accumulation list for timing.id(r)rather thanr.nodeid, allowing independent timing reports.self._current_logreportto ensure correct file location detection.Attribution
This pull request was implemented with assistance from AI coding tools (Antigravity), credited via the
Co-authored-bytrailer in the commit history according to pytest's contribution guidelines.Co-authored-by: Shimon Schwartz (@shimonenator)
Co-authored-by: Antigravity