-
Notifications
You must be signed in to change notification settings - Fork 316
chore(lazer) Lazer Contract changes #3286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ali-behjati
approved these changes
Dec 10, 2025
6655574 to
db3da20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The library functions use bytes calldata for efficient slicing
function parseUpdateFromPayload(bytes calldata payload) internal pureYou cannot pass bytes memory to an internal function that expects bytes calldata. The Solidity compiler won't allow it.
The
PythLazerLibTestHelpercontract wraps the internal library functions with external functionsPythLazer.soldoesn't need a helper because its external functions already receive bytes calldata directly from usersIt's just for testing via solidity.
How has this been tested?