Skip to content

Conversation

@aditya520
Copy link
Member

@aditya520 aditya520 commented Dec 10, 2025

Summary

Rationale

The library functions use bytes calldata for efficient slicing
function parseUpdateFromPayload(bytes calldata payload) internal pure
You cannot pass bytes memory to an internal function that expects bytes calldata. The Solidity compiler won't allow it.

The PythLazerLibTestHelper contract wraps the internal library functions with external functions

PythLazer.sol doesn't need a helper because its external functions already receive bytes calldata directly from users

It's just for testing via solidity.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
api-reference Ready Ready Preview Comment Dec 11, 2025 8:11pm
component-library Ready Ready Preview Comment Dec 11, 2025 8:11pm
developer-hub Ready Ready Preview Comment Dec 11, 2025 8:11pm
entropy-explorer Ready Ready Preview Comment Dec 11, 2025 8:11pm
insights Ready Ready Preview Comment Dec 11, 2025 8:11pm
proposals Ready Ready Preview Comment Dec 11, 2025 8:11pm
staking Ready Ready Preview Comment Dec 11, 2025 8:11pm

@aditya520 aditya520 marked this pull request as ready for review December 10, 2025 15:34
@aditya520 aditya520 changed the title chore(lazer) Lazer Contract and Script changes chore(lazer) Lazer Contract changes Dec 10, 2025
@vercel vercel bot temporarily deployed to Preview – proposals December 10, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – staking December 10, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer December 10, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – insights December 10, 2025 16:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants