(fix): dev hub refactor for home page and improved dark mode styles #3290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and shared components; fix Fuel SDK package type definitions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
…ant image container from homepage section cards.
alexcambose
reviewed
Dec 11, 2025
| "name": "Pyth Data Association" | ||
| }, | ||
| "main": "./dist/cjs/index.cjs", | ||
| "types": "./dist/cjs/index.d.ts", |
Contributor
There was a problem hiding this comment.
there's some weird things going on here when building this package, can you revert this
|
|
||
| .dark { | ||
| /* | ||
| OLD COLORS |
Contributor
There was a problem hiding this comment.
might as well just remove these?
| {icon && <div className={styles.icon}>{icon}</div>} | ||
| <div className="bg-fd-card rounded-xl border border-fd-border overflow-hidden"> | ||
| <div className="p-6 border-b border-fd-border h-[250px] flex flex-col justify-between items-start"> | ||
| <div className="flex flex-col gap-4 items-start"> |
Contributor
There was a problem hiding this comment.
I don't think we should combine tailwind with css modules. Becomes hard to read and not consistent anymore with how we write styles. I would suggest writing this with css modules instead and if you need some sizing from tailwind then either see if we have that in the theme.scss or then manually add it eg x rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a significant visual refresh of the Developer Hub Homepage and addresses TypeScript strictness errors.
Key changes:
ProductCard, andFooterto use a modern design with Tailwind utility classes, improved spacing, and gradients.BoxSVGcomponent for enhanced visual flair in the "Additional Resources" section.ProductCardand parts of the Homepage from CSS modules to Tailwind CSS.exactOptionalPropertyTypeserrors inProductCardConfigTypeby explicitly allowingundefinedfor optional properties.Rationale
These changes are necessary to elevate the design quality of the Developer Hub, matching updated brand aesthetics. The refactor to utility classes simplifies styles and improves consistency. The TypeScript fixes ensure the codebase complies with stricter compiler options (
exactOptionalPropertyTypes) enabled in the project.How has this been tested?
Verification Steps:
ProductCardConfigTypeis resolved.BoxSVG.ProductCardcomponents render features with their new icons and improved styling.