Skip to content

policies: tighten screws #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hynek merged 1 commit into from
Mar 14, 2026
+14 −5
Merged

policies: tighten screws #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,16 @@ It's people like *you* who make this project such a great tool for everyone.
- **Only contribute code that you fully understand.**
See also our [AI policy][llm].

- Very relatedly, our pull request check list is our mandatory [Van Halen test](https://en.wikipedia.org/wiki/Van_Halen_test).
Sadly, the current state of the world has forced us into being stricter about policies -- sorry fellow humans!

- No contribution is too small!
Please submit as many fixes for typos and grammar bloopers as you can!
They're your license to delete the checklist!

- Before starting big contributions, **talk to us first**.
Don't waste energy / tokens on something that we do not want.
Rejecting a huge PR is unpleasant for everybody.

- Try to limit each pull request to *one* change only.

Expand Down
11 changes: 6 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@
# Pull Request Check List

<!--
This is just a friendly reminder about the most common mistakes.
Please make sure that you tick all boxes.
This list is our brown M&M test:
Ignoring -- or even deleting -- leads to instant closing of this pull request.
The only exception are pure documentation fixes.

But please read our [contribution guide](https://github.com/python-attrs/attrs/blob/main/.github/CONTRIBUTING.md) at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, **check it anyway** to make it apparent that there's nothing left to do.
If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.
You may check boxes that don't apply to your pull request to indicate that there isn't anything left to do.
-->

- [ ] I acknowledge this project's [**AI policy**](https://github.com/python-attrs/attrs/blob/main/.github/AI_POLICY.md).
Expand All @@ -34,5 +35,5 @@ If your pull request is a documentation fix or a trivial typo, feel free to dele

<!--
If you have *any* questions to *any* of the points above, just **submit and ask**!
This checklist is here to *help* you, not to deter you from contributing!
Given the ongoing AI slop wave we need to be strict about policies, but we're happy to help out fellow humans.
-->
Loading