Add beforeunload event listener when a form is open #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make the browser prompt the user before they try to reload or close the page if they have a form open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the browser will prompt the user before it tries to close the page, that way someone cannot accidentally close the page mid-submission.
Currently this does not work for the home
aelement (Python Discord logo), for some reason it does not appear to trigger thebeforeunloadevent that we subscribe to. Further investigation could be made into adding anonclickto this element that will throw a similar prompt and potentially cancel, or find a way to also triggerbeforeunloadevents when clicking this element.