Adding AWS ECS task definition validation.

[djgoku]

Since #353 was merged this is now working! Thanks again for adding support in for #353 !

% check-jsonschema --builtin-schema vendor.amazon-ecs-intellisense-schema tests/example-files/hooks/positive/amazon-ecs-intellisense-schema/fargate.json
ok -- validation done

% check-jsonschema --builtin-schema vendor.amazon-ecs-intellisense-schema tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json
Schema validation errors were encountered.
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'family' is a required property
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'containerDefinitions' is a required property

[sirosen]

Hi there, thanks for the pull request!

Right now, I'm disinclined to accept this addition, but it may be possible for you to change my mind.

Issues:

• the schema is not in schemastore (not a hard blocker, but a mark against it)
• the user base for https://github.com/awslabs/amazon-ecs-intellisense-schema/ appears very small -- only 15 stars
• awslabs in particular produces a lot of abandonware, and this project seems like it's mostly abandoned (it's getting minimal maintenance updates once a year, and has some very long update droughts)
• there is no canonically correct filename pattern

I wish I had some more formal acceptance criteria for schemas (for me, so that I didn't have to make this a judgement call, and for you, so you could have clearer criteria to satisfy), but for now the rough rule is "if it's not in SchemaStore, make a convincing case for it".

Keeping in mind that a non-vendored schema can be used either by URL or by downloading it yourself, are you able to solve your particular use cases without this change? If not, why not (so that I better understand usages)?

---

If you want to push this forward, I think it would help to get the schema added to SchemaStore's catalog. They're very welcoming over there, so it shouldn't be hard unless there's some blocking issue with the schema. That way, I could at least keep to the rule that check-jsonschema's vendoring tracks SchemaStore.

[djgoku]

@sirosen, I completely understand your perspective! I concur with all your points.

I also want to express my gratitude for your work on #353, as it would not have been possible without it.

Here’s a bit of a clue for anyone searching the repository for a similar issue:

Happy Path:

% check-jsonschema --schemafile https://raw.githubusercontent.com/awslabs/amazon-ecs-intellisense-schema/mainline/src/model/schema/schema.json tests/example-files/hooks/positive/amazon-ecs-intellisense-schema/fargate.json 
ok -- validation done

Not happy path:

% check-jsonschema --schemafile https://raw.githubusercontent.com/awslabs/amazon-ecs-intellisense-schema/mainline/src/model/schema/schema.json tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json 
Schema validation errors were encountered.
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'family' is a required property
  tests/example-files/hooks/negative/amazon-ecs-intellisense-schema/invalid.json::$: 'containerDefinitions' is a required property