Add official support for Python 3.14 #617
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
approved these changes
Nov 10, 2025
Member
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
Thanks for this!
I need to add 3.14 to a bunch of my projects; every bit of help counts. ❤️
| @pytest.mark.skipif( | ||
| platform.system() == "Windows", | ||
| reason="time.tzset() is not available on Windows", | ||
| ) |
Member
There was a problem hiding this comment.
😢 I should probably go back over the test to figure out a compatible way of setting the timezone. But this will do for now.
Contributor
Author
There was a problem hiding this comment.
Yeah, FWIW I noticed this on main (e.g. https://github.com/python-jsonschema/check-jsonschema/actions/runs/19238976727/job/54996498981) and thought it was a good idea to handle it in this PR.
I don't know of any good alternatives for monkeypatching the timezone, unfortunately 😕.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.