async100 now ignores trio.open_nursery and anyio.create_task_group #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
approved these changes
Nov 15, 2024
docs/changelog.rst
Outdated
| @@ -4,6 +4,10 @@ Changelog | |||
|
|
|||
| `CalVer, YY.month.patch <https://calver.org/>`_ | |||
|
|
|||
| 24.11.1 | |||
| ====== | |||
| - :ref:`ASYNC100 <async100>` now ignores :func:`trio.open_nursery` and :func:`anyio.create_task_group` as cancellation sources. | |||
There was a problem hiding this comment.
Suggested change
| - :ref:`ASYNC100 <async100>` now ignores :func:`trio.open_nursery` and :func:`anyio.create_task_group` as cancellation sources. | |
| - :ref:`ASYNC100 <async100>` now ignores :func:`trio.open_nursery` and :func:`anyio.create_task_group` as cancellation sources, | |
| because they are schedule points but not cancellation points. |
This is a subtle enough concept that we should not assume users are familiar with it - I'd also call out this distinction in the docs for ASYNC100, and create glossary entries for both which are linked from "checkpoint" and link in turn to Trio docs (eg for cancel_shielded_checkpoint() and checkpoint_if_cancelled())
There was a problem hiding this comment.
good call, feel free to reword my attempt :)
jakkdl
commented
Nov 17, 2024
jakkdl
added a commit
to jakkdl/flake8-async
that referenced
this pull request
Nov 19, 2024
…ursery and anyio.create_task_group (python-trio#317)" This partially reverts commit 7a45176.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was cleaning up old branches in my fork, and it... seems like I never opened a PR for this? Wrote it several months ago, so decided to just rebase and clean it up