Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): pin pytest to 7.1.3 #690

Closed
wants to merge 1 commit into from

Conversation

bringhurst
Copy link
Contributor

@bringhurst bringhurst commented Jan 19, 2023

Why is this needed?

This change is intended to avoid errors like the following at build (tox) time:

ModuleNotFoundError: No module named 'py'

pytest removed the dependency on py in:

pytest-dev/pytest@19dda7c

This change pins the version of pytest to one that includes py until a path forward can be agreed on (e.g. include py explicitly or via a transitive dependency).

Proposed Changes

  • Pin pytest from latest (currently 7.2.1) to 7.1.3.

Does this PR introduce any breaking change?

No. This change affects build/test only.

@bringhurst bringhurst changed the title Pin pytest to 7.1.3 chore(core): pin pytest to 7.1.3 Jan 19, 2023
pytest removed their dependency on py in:

pytest-dev/pytest@19dda7c

This change pins pytest to 7.1.3 until a path forward is chosen.
@bringhurst
Copy link
Contributor Author

bringhurst commented Jan 19, 2023

Closing this. Although this is a problem -- the real issue I was seeing is that tox-wheel is deprecated and doesn't work with tox 4. See #691 instead.

@bringhurst bringhurst closed this Jan 19, 2023
@bringhurst bringhurst deleted the pin_pytest branch January 19, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant